PMD Results

The following document contains the results of PMD 3.7.

Files

org/apache/struts/action/ActionForm.java

ViolationLine
An empty statement (semicolon) not part of a loop154

org/apache/struts/action/ActionMapping.java

ViolationLine
These nested if statements could be combined76 - 78

org/apache/struts/action/ActionServlet.java

ViolationLine
Avoid unused imports such as 'org.xml.sax.InputSource'57
Avoid unused imports such as 'java.net.URLConnection'75
An empty statement (semicolon) not part of a loop314
An empty statement (semicolon) not part of a loop854
These nested if statements could be combined1000 - 1026
These nested if statements could be combined1148 - 1174
These nested if statements could be combined1295 - 1321
These nested if statements could be combined1456 - 1490

org/apache/struts/action/RequestProcessor.java

ViolationLine
These nested if statements could be combined455 - 457
These nested if statements could be combined464 - 466

org/apache/struts/chain/commands/servlet/ExceptionHandler.java

ViolationLine
Avoid unused private fields such as 'log'47

org/apache/struts/chain/commands/servlet/PopulateActionForm.java

ViolationLine
Avoid unused private fields such as 'log'42

org/apache/struts/chain/commands/servlet/SelectLocale.java

ViolationLine
Avoid unused private fields such as 'log'41

org/apache/struts/chain/commands/servlet/ValidateActionForm.java

ViolationLine
These nested if statements could be combined64 - 70

org/apache/struts/chain/contexts/WebActionContext.java

ViolationLine
Overriding method merely calls super53 - 55

org/apache/struts/config/impl/ModuleConfigImpl.java

ViolationLine
These nested if statements could be combined297 - 307

org/apache/struts/mock/MockActionServlet.java

ViolationLine
An empty statement (semicolon) not part of a loop62
Overriding method merely calls super105 - 108

org/apache/struts/mock/MockFormBean.java

ViolationLine
Do not use if statements that are always true or always false94

org/apache/struts/upload/CommonsMultipartRequestHandler.java

ViolationLine
Avoid empty catch blocks406 - 408

org/apache/struts/util/ImageButtonBean.java

ViolationLine
An empty statement (semicolon) not part of a loop55

org/apache/struts/util/PropertyMessageResources.java

ViolationLine
Avoid empty if statements250
Avoid unused local variables such as 'messageKey'397
These nested if statements could be combined448 - 450

org/apache/struts/util/RequestUtils.java

ViolationLine
An empty statement (semicolon) not part of a loop839

org/apache/struts/util/TokenProcessor.java

ViolationLine
Avoid unnecessary temporaries when converting primitives to Strings204

org/apache/struts/validator/Resources.java

ViolationLine
Avoid unused local variables such as 'msgBundle'296

org/apache/struts/validator/ValidatorPlugIn.java

ViolationLine
Avoid unused private fields such as 'config'79

org/apache/struts/validator/validwhen/ValidWhenLexer.java

ViolationLine
Avoid unused imports such as 'java.util.Stack'26
Avoid unused imports such as 'org.apache.commons.validator.util.ValidatorUtils'27
Avoid unused imports such as 'antlr.ANTLRException'36
Avoid unused imports such as 'antlr.CharScanner'39
Avoid unused imports such as 'antlr.CommonToken'44
Avoid unused imports such as 'antlr.MismatchedCharException'47
Avoid unused imports such as 'antlr.SemanticException'52
Avoid unused local variables such as 'theRetToken'76
Avoid unused local variables such as '_token'79
Avoid unused local variables such as '_saveIndex'213
Avoid unused local variables such as '_saveIndex'259
Avoid unused local variables such as '_saveIndex'305
Avoid unused local variables such as '_saveIndex'345
Avoid unused local variables such as '_saveIndex'370
Avoid unused local variables such as '_saveIndex'432
Avoid unused local variables such as '_saveIndex'445
Avoid unused local variables such as '_saveIndex'458
Avoid unused local variables such as '_saveIndex'471
Avoid unused local variables such as '_saveIndex'484
Avoid unused local variables such as '_saveIndex'497
Avoid unused local variables such as '_saveIndex'579
Avoid unused local variables such as '_saveIndex'593
Avoid unused local variables such as '_saveIndex'607
Avoid unused local variables such as '_saveIndex'620
Avoid unused local variables such as '_saveIndex'633
Avoid unused local variables such as '_saveIndex'647

org/apache/struts/validator/validwhen/ValidWhenParser.java

ViolationLine
Avoid unused imports such as 'antlr.TokenStreamIOException'32
Avoid unused imports such as 'antlr.ANTLRException'33
Avoid unused imports such as 'antlr.LLkParser'34
Avoid unused imports such as 'antlr.MismatchedTokenException'39
Avoid unused imports such as 'antlr.SemanticException'40
These nested if statements could be combined72 - 74
These nested if statements could be combined77 - 79
Avoid empty catch blocks133
An empty statement (semicolon) not part of a loop133
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.407
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.422
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.424

org/apache/struts/validator/validwhen/ValidWhenParserTokenTypes.java

ViolationLine
Avoid unused imports such as 'java.util.Stack'26
Avoid unused imports such as 'org.apache.commons.validator.util.ValidatorUtils'27